-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate online events #5012
feat: Integrate online events #5012
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/djslcg3y7 |
New events seem to be working fine. Existing events show a line when choosing "Online". |
Thanks, will check. |
That might be a bug, but I have made it publishable without needing links. The work isn't complete since it was blocked by fossasia/open-event-server#7251 |
@mariobehling Please check now. I have not yet completed I'll do it in another PR |
Codecov Report
@@ Coverage Diff @@
## development #5012 +/- ##
===============================================
+ Coverage 22.66% 22.69% +0.02%
===============================================
Files 485 485
Lines 5153 5165 +12
Branches 21 21
===============================================
+ Hits 1168 1172 +4
- Misses 3981 3989 +8
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. I think remaining points can be done at a later time. Lets move forward.
Fixes #4611