Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate online events #5012

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 8, 2020

Fixes #4611

@vercel
Copy link

vercel bot commented Sep 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/djslcg3y7
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-online-events.eventyay.vercel.app

@mariobehling mariobehling changed the title feat: Interate online events feat: Integrate online events Sep 8, 2020
@mariobehling
Copy link
Member

mariobehling commented Sep 8, 2020

New events seem to be working fine. Existing events show a line when choosing "Online".

E.g. compare https://open-event-frontend-git-fork-iamareebjamal-online-events.eventyay.vercel.app/events/16fa59c7/edit/basic-details

Screenshot from 2020-09-08 14-06-52

@iamareebjamal
Copy link
Member Author

Thanks, will check.

@mariobehling
Copy link
Member

It should be possible to publish an online event without adding URLs.
In the implementation of the PR it is not possible yet to publish an online event without adding URLs.

Screenshot from 2020-09-08 14-41-54

@iamareebjamal
Copy link
Member Author

That might be a bug, but I have made it publishable without needing links. The work isn't complete since it was blocked by fossasia/open-event-server#7251

@iamareebjamal
Copy link
Member Author

@mariobehling Please check now. I have not yet completed Show a tick box "Details will be shared as follows (e.g. you can share links in the session info: _Add__message___here." If the user chooses this message, display this message if the user on the public event page.

I'll do it in another PR

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #5012 into development will increase coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5012      +/-   ##
===============================================
+ Coverage        22.66%   22.69%   +0.02%     
===============================================
  Files              485      485              
  Lines             5153     5165      +12     
  Branches            21       21              
===============================================
+ Hits              1168     1172       +4     
- Misses            3981     3989       +8     
  Partials             4        4              
Impacted Files Coverage Δ
app/mixins/event-wizard.js 1.07% <0.00%> (-0.07%) ⬇️
app/models/event.js 53.84% <ø> (ø)
app/components/forms/wizard/basic-details-step.js 21.51% <44.44%> (+2.94%) ⬆️
app/controllers/admin/content/pages.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacd1ba...4124789. Read the comment docs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I think remaining points can be done at a later time. Lets move forward.

@iamareebjamal iamareebjamal merged commit 5b7251b into fossasia:development Sep 9, 2020
@iamareebjamal iamareebjamal deleted the online-events branch September 9, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Event Details: Enable option Online Events or Mixed Event
2 participants